NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar (extended) #434
Conversation
No need to use a slice. Signed-off-by: Stephen Finucane <[email protected]>
The 'InjectKubeRBACProxy' field was was always set to True in users and was therefore a no-op. The 'Name' field was likewise always set to 'driver-m' and doesn't need to be templated. Flatten the remaining two fields into the parent structs and remove MetricsPorts entirely. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
This aligns us closer with the other sidecar containers own metrics sidecars. This is also, coincidentally, the first and only change in the series of changes that actually has an effect on the generated assets. Signed-off-by: Stephen Finucane <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This builds on #380 by changing the name of the proxy sidecar used for driver metrics.